sntp: avoid use of uninitialized variable

When we use the ntpserverip environment variable argv[1] may not be set.
Printing the error message using the NetNtpServerIP variable ensures the
correct output in both cases.

Signed-off-by: Luuk Paulussen <[email protected]>
Acked-by: Chris Packham <[email protected]>
Cc: Ben Warren <[email protected]>
Acked-by: Detlev Zundel <[email protected]>

diff --git a/common/cmd_net.c b/common/cmd_net.c
index b2c9355a21abe2db2622b03be5a0b9a8b87370fd..75ba1c3cdcece26a8cbf918255918a49cf71f689 100644 (file)
--- a/common/cmd_net.c
+++ b/common/cmd_net.c
@@ -341,7 +341,8 @@ int do_sntp (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
        else NetTimeOffset = simple_strtol (toff, NULL, 10);
 
        if (NetLoop(SNTP) < 0) {
-               printf("SNTP failed: host %s not responding\n", argv[1]);
+               printf("SNTP failed: host %pI4 not responding\n",
+                       &NetNtpServerIP);
                return 1;
        }